Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to address volumepopulator test flake #778

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Try to address volumepopulator test flake #778

merged 1 commit into from
Jun 29, 2023

Conversation

tesshuflower
Copy link
Contributor

  • updates to error out in Eventually() if we do get a flake to help debug if the issue still happens intermittently.

Describe what this PR does

Try to address test flake that's occurred a couple times:

  [FAILED] Timed out after 60.001s.
  Expected
      <bool>: false
  to be true
  In [JustBeforeEach] at: /home/runner/work/volsync/volsync/controllers/volumepopulator_controller_test.go:688 @ 06/19/23 18:54:52.177
------------------------------
•••••••••••••••••••••••••••••••••••••••••••••••

Summarizing 1 Failure:
  [FAIL] VolumePopulator When a PVC is created that has a dataSourceRef with replicationdestination and a storageClassName When a storageclassname is specified in the pvc spec When the storageClass exists and latestImage snap is set on the RD [JustBeforeEach] When pvcPrime gets a PV bound When pvcPrime loses claim (bind controller rebinds the PV to pvc from pvcPrime) When snapshot has do-not-delete label Should cleanup pvcPrime (and volumesnapshot if necessary)
  /home/runner/work/volsync/volsync/controllers/volumepopulator_controller_test.go:688

Is there anything that requires special attention?

Related issues:

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/M and removed size/S labels Jun 23, 2023
@codecov
Copy link

codecov bot commented Jun 23, 2023 •
edited
Loading

Codecov Report

Merging #778 (c576c54) into main (ec4bcc2) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main    #778   +/-   ##
=====================================
  Coverage   66.8%   66.9%           
=====================================
  Files         55      55           
  Lines       7054    7055    +1     
=====================================
+ Hits        4719    4726    +7     
+ Misses      2056    2052    -4     
+ Partials     279     277    -2

see 1 file with indirect coverage changes

@tesshuflower
Try to address volumepopulator test flake
c576c54 
- updates to error out in Eventually() if we do get a flake
  to help debug if the issue still happens intermittently.

Signed-off-by: Tesshu Flower <tflower@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tesshuflower
Copy link
Contributor Author

/retest

2 similar comments
@tesshuflower
Copy link
Contributor Author

/retest

@tesshuflower
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023 •
edited
Loading

@tesshuflower: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-index-volsync-bundle c576c54 link true /test ci-index-volsync-bundle

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tesshuflower
Copy link
Contributor Author

/retest

@tesshuflower
Copy link
Contributor Author

/cc @JohnStrunk

@openshift-ci openshift-ci bot requested a review from JohnStrunk June 29, 2023 12:56
JohnStrunk
JohnStrunk reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 29, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2cafe1c into backube:main Jun 29, 2023
@tesshuflower tesshuflower deleted the vol_pop_test_flake branch June 29, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnStrunk JohnStrunk JohnStrunk left review comments

Assignees

@JohnStrunk JohnStrunk

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tesshuflower @JohnStrunk @openshift-merge-robot